Breadcrumbs refactor

[skjnldsv]

Summary here: #7051 (comment)

Fix #5431, fix #6756
Closes #5229

Rebuilding the breadcrumbs design and calculation system for a better result:

• Flexi flexo magic
• Calculate what elements to hide
• Auto hide
• Put hidden elements in a popover
• Mobile style
• Fix click feedback and sidebar opening
• Animation ?
• Fix file picker
• Tests ⚠️
• Performance optimisations
  • There are multiple calls for BreadCrumb.setDirectoryInfo & BreadCrumb.setDirectory which force re-renders
  • There are at least 3 BreadCrumb._resize execution on init, only one is needed

[codecov]

Codecov Report

Merging #7051 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #7051      +/-   ##
============================================
+ Coverage     50.72%   50.74%   +0.01%     
  Complexity    24478    24478              
============================================
  Files          1581     1581              
  Lines         93578    93560      -18     
  Branches       1359     1353       -6     
============================================
+ Hits          47471    47475       +4     
+ Misses        46107    46085      -22

Impacted Files	Coverage Δ	Complexity Δ
core/js/js.js	63.55% <ø> (+1.72%)	0 <0> (ø)	⬇️
core/js/oc-dialogs.js	0.43% <0%> (ø)	0 <0> (ø)	⬇️
apps/files_trashbin/lib/Expiration.php	90.32% <0%> (-1.62%)	29% <0%> (ø)
lib/private/Server.php	83.29% <0%> (-0.13%)	125% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php	72.53% <0%> (+0.24%)	136% <0%> (ø)	⬇️
lib/private/Security/CertificateManager.php	92.07% <0%> (+0.99%)	39% <0%> (ø)	⬇️

[skjnldsv]

@jancborchardt @juliushaertl @nextcloud/javascript
Do we have a specific function that handle a menu open/close and a click outside menu behaviour?

[skjnldsv]

BreadCrumb.setDirectoryInfo is used to re-render the apps that add their buttons in the breadcrumb (like the sharing button) so we can't disabled the second rendering after BreadCrumb.setDirectory.

Pretty much the same for the resize function! 😕

[skjnldsv]

@rullzer, @MorrisJobke, @juliushaertl, @jancborchardt, @ChristophWurst, please help and test it. 😭

[MorrisJobke]

Even with the latest changes the popup does not show up in Chrome nor in Safari and there is nothing in the console :/

[MorrisJobke]

Tested and works now (after disabling the gallery app) 👍

[MorrisJobke]

Please revert this.

[skjnldsv]

Of course, it was for testing purposes only! :)

[jancborchardt]

With the Gallery fix nextcloud/gallery#325 it seems good now! :) Great work!

[MorrisJobke]

@skjnldsv Is this ready for merge or not? (because the label says something different ;))

[skjnldsv]

It is, I was waiting for other tests to be sure if this was a pr issue or something from @blizzz dev environnement. :)

[blizzz]

Still broken from me, also pristine from git -.- Ill open issues