feat: author displayname and avatar on versions#44109
Merged
Conversation
This was referenced Mar 9, 2024
7049690 to
5f16f3c
Compare
148aa46 to
bfacc6d
Compare
Merged
5f16f3c to
08c71bc
Compare
Merged
08c71bc to
eba635d
Compare
Contributor
Author
|
This PR will only show the visual changes once NcVue gets a bump to use one of the chained PR's, but for now, no breaking changes are introduced with this PR, so this can get in before I go on vacation 👀 |
susnux
reviewed
Mar 14, 2024
artonge
approved these changes
Mar 14, 2024
nimishavijay
requested changes
Mar 14, 2024
Member
There was a problem hiding this comment.
Awesome! What a cool feature! :)
- I would only suggest that the positions of the avatar and name be exchanged, and the avatar size be decreased so that it looks a bit more like a user bubble
- everything in the first time can be in
--color-main-textand everything on the subline can be--color-text-maxcontrast:)
eba635d to
bcff895
Compare
Contributor
Author
@nimishavijay |
bcff895 to
3d01107
Compare
susnux
approved these changes
Mar 14, 2024
Contributor
Author
|
waiting for a bump to |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
3d01107 to
ac62523
Compare
Contributor
|
/compile |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
cefe7bf to
56eebaf
Compare
Merged
|
Hi, |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is a stacked PR
Summary
With the aforementioned PR's, this PR will allow file_version to display the author and avatar for each version
Checklist