feat: show the id of last author in versions metadata by emoral435 · Pull Request #44049 · nextcloud/server

emoral435 · 2024-03-06T23:52:31Z

For feat: author displayname and avatar on versions #44109

Summary

The oc_files_version table is what stores the version information of each file. Each version can be categorized by its file_id and timestamp columns, but there is also a metadata column which stores JSON directly.
Everytime the file node is overwritten, we should have an event listener that gets triggered and updates that meta data column with:

{
  "author": "versionAuthorID",
}

This PR also allows us to also potentially store messages that go along with a file version change, similar to a git commit in future releases! I tried to make this as flexible as possible, and also to make a PR as small as possible, but I believe these commits have to be bundled together to allow for a better sense while reading this commit 😋

Screenshots

Untitled.video.-.Made.with.Clipchamp.6.mp4

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

apps/files_versions/lib/Listener/FileEventsListener.php

apps/files_versions/lib/Versions/LegacyVersionsBackend.php

apps/files_versions/lib/Listener/MetadetaFileEvents.php

apps/files_versions/lib/Versions/IStoreMetadataBackend.php

susnux

Nice, I like that you are using proper doc comments :)

apps/files_versions/lib/Sabre/VersionFile.php

apps/files_versions/lib/Versions/VersionManager.php

apps/files_versions/lib/Sabre/Plugin.php

apps/files_versions/lib/Sabre/VersionFile.php

apps/files_versions/lib/Listener/MetadataFileEvents.php

susnux · 2024-03-11T14:02:05Z

Really nice work 🚀 Just a few nitpicks and comments :)

emoral435 · 2024-03-11T15:35:16Z

I fixed the inconsistent typing of variables within functions, bad use of double-quotes, and licensing :) Just need to do documentation, but as I am at university currently, I will save that for when I get back home! 🚀 will edit this comment to include the updated documentations PR

susnux

thank you!

Signed-off-by: Eduardo Morales <emoral435@gmail.com>

As of: nextcloud/server#44049 Server equivalent: nextcloud/server#44175 Signed-off-by: Louis Chemineau <louis@chmn.me>

github-advanced-security bot found potential problems Mar 6, 2024

View reviewed changes

apps/files_versions/lib/Listener/FileEventsListener.php Fixed Show fixed Hide fixed

apps/files_versions/lib/Versions/LegacyVersionsBackend.php Fixed Show fixed Hide fixed

emoral435 changed the title ~~feat: in progress...~~ feat: show the name of last editor in versions Mar 7, 2024

emoral435 self-assigned this Mar 7, 2024

emoral435 added 2. developing Work in progress feature: versions 🍀 2024-Spring labels Mar 7, 2024

emoral435 added this to the Nextcloud 29 milestone Mar 7, 2024

emoral435 force-pushed the feat/show-name-of-user-in-versions branch from 3a2eb8c to 694090a Compare March 7, 2024 16:11

github-advanced-security bot found potential problems Mar 7, 2024

View reviewed changes

apps/files_versions/lib/Listener/MetadetaFileEvents.php Fixed Show fixed Hide fixed

apps/files_versions/lib/Listener/MetadetaFileEvents.php Fixed Show fixed Hide fixed

susnux reviewed Mar 7, 2024

View reviewed changes

apps/files_versions/lib/Listener/MetadetaFileEvents.php Show resolved Hide resolved

susnux reviewed Mar 7, 2024

View reviewed changes

apps/files_versions/lib/Versions/IStoreMetadataBackend.php Outdated Show resolved Hide resolved

susnux reviewed Mar 7, 2024

View reviewed changes

apps/files_versions/lib/Versions/IStoreMetadataBackend.php Outdated Show resolved Hide resolved

susnux reviewed Mar 7, 2024

View reviewed changes

emoral435 force-pushed the feat/show-name-of-user-in-versions branch 2 times, most recently from e429295 to 130df29 Compare March 8, 2024 15:18

github-advanced-security bot found potential problems Mar 8, 2024

View reviewed changes

emoral435 force-pushed the feat/show-name-of-user-in-versions branch 2 times, most recently from 39cb2b1 to f1a6ffe Compare March 8, 2024 15:47

github-advanced-security bot found potential problems Mar 8, 2024

View reviewed changes

apps/files_versions/lib/Listener/MetadataFileEvents.php Fixed Show fixed Hide fixed

apps/files_versions/lib/Listener/MetadataFileEvents.php Fixed Show fixed Hide fixed

apps/files_versions/lib/Listener/MetadataFileEvents.php Fixed Show fixed Hide fixed

emoral435 force-pushed the feat/show-name-of-user-in-versions branch 2 times, most recently from 59ba0b3 to 2f42bbf Compare March 9, 2024 17:05

github-advanced-security bot found potential problems Mar 9, 2024

View reviewed changes

apps/files_versions/lib/Listener/MetadataFileEvents.php Fixed Show fixed Hide fixed

apps/files_versions/lib/Listener/MetadataFileEvents.php Fixed Show fixed Hide fixed

apps/files_versions/lib/Listener/MetadataFileEvents.php Fixed Show fixed Hide fixed

emoral435 force-pushed the feat/show-name-of-user-in-versions branch from 2f42bbf to 33903d8 Compare March 9, 2024 17:22

github-advanced-security bot found potential problems Mar 9, 2024

View reviewed changes

apps/files_versions/lib/Listener/MetadataFileEvents.php Fixed Show fixed Hide fixed

emoral435 force-pushed the feat/show-name-of-user-in-versions branch 2 times, most recently from 77ed897 to ae7dfbd Compare March 9, 2024 18:39

emoral435 mentioned this pull request Mar 9, 2024

feat: author displayname and avatar on versions #44109

Merged

3 tasks

emoral435 force-pushed the feat/show-name-of-user-in-versions branch from ae7dfbd to 9651041 Compare March 10, 2024 17:18

emoral435 marked this pull request as ready for review March 10, 2024 17:19

emoral435 requested a review from susnux March 10, 2024 17:19

artonge added the pending documentation This pull request needs an associated documentation update label Mar 11, 2024

emoral435 requested a review from susnux March 11, 2024 15:35

artonge approved these changes Mar 11, 2024

View reviewed changes

susnux approved these changes Mar 11, 2024

View reviewed changes

emoral435 changed the title ~~feat: show the name of last editor in versions~~ feat: show the id of last author in versions Mar 11, 2024

emoral435 changed the title ~~feat: show the id of last author in versions~~ feat: show the id of last author in versions metadata Mar 11, 2024

emoral435 added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Mar 11, 2024

emoral435 force-pushed the feat/show-name-of-user-in-versions branch from 015f5ab to 148aa46 Compare March 11, 2024 18:10

emoral435 added 7 commits March 11, 2024 15:57

feat: added metadata event listener

88b40bb

Signed-off-by: Eduardo Morales <emoral435@gmail.com>

feat: added backend metadata interface, allows JSON storage

b2c8554

Signed-off-by: Eduardo Morales <emoral435@gmail.com>

feat: exposed metadata column to frontend

4cf4fdc

Signed-off-by: Eduardo Morales <emoral435@gmail.com>

fix(files_version): deprecated INameableVersion

a8844d4

Signed-off-by: Eduardo Morales <emoral435@gmail.com>

fix: fixed stylistic errors

c5d1fda

Signed-off-by: Eduardo Morales <emoral435@gmail.com>

chore(assets): build autoloader

5c6be88

Signed-off-by: Eduardo Morales <emoral435@gmail.com>

chore(assets): compile assets

bfacc6d

Signed-off-by: Eduardo Morales <emoral435@gmail.com>

emoral435 force-pushed the feat/show-name-of-user-in-versions branch from 148aa46 to bfacc6d Compare March 11, 2024 20:58

emoral435 enabled auto-merge March 11, 2024 20:58

emoral435 merged commit f99b820 into master Mar 11, 2024

emoral435 deleted the feat/show-name-of-user-in-versions branch March 11, 2024 21:17

Altahrim mentioned this pull request Mar 12, 2024

29.0.0 beta 2 #44152

Merged

artonge mentioned this pull request Mar 13, 2024

chore(files_versions): Use new metadata API for versions #44175

Merged

artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 13, 2024

chore(files_versions): Use new metadata API for versions

fbebb4c

As of: nextcloud/server#44049 Server equivalent: nextcloud/server#44175 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge mentioned this pull request Mar 13, 2024

chore(files_versions): Use new metadata API for versions nextcloud/groupfolders#2857

Merged

artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 13, 2024

chore(files_versions): Use new metadata API for versions

2a8062a

As of: nextcloud/server#44049 Server equivalent: nextcloud/server#44175 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 18, 2024

chore(files_versions): Use new metadata API for versions

cf5fb4b

As of: nextcloud/server#44049 Server equivalent: nextcloud/server#44175 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 18, 2024

chore(files_versions): Use new metadata API for versions

79ed5ad

As of: nextcloud/server#44049 Server equivalent: nextcloud/server#44175 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit to nextcloud/groupfolders that referenced this pull request Mar 18, 2024

chore(files_versions): Use new metadata API for versions

bb59297

As of: nextcloud/server#44049 Server equivalent: nextcloud/server#44175 Signed-off-by: Louis Chemineau <louis@chmn.me>

Uh oh!

Conversation

emoral435 commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

susnux commented Mar 11, 2024

Uh oh!

emoral435 commented Mar 11, 2024

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

emoral435 commented Mar 6, 2024 •

edited

Loading