Skip to content

Prevents the selection of encrypted folders when clicking on the "Select all" checkbox#35299

Merged
PVince81 merged 7 commits intonextcloud:masterfrom
nextmcloud:nmcpr/1416-prevents-selection-of-encrypted-folders
Nov 22, 2022
Merged

Prevents the selection of encrypted folders when clicking on the "Select all" checkbox#35299
PVince81 merged 7 commits intonextcloud:masterfrom
nextmcloud:nmcpr/1416-prevents-selection-of-encrypted-folders

Conversation

@TSI-kavitasonawane
Copy link
Contributor

No description provided.

@artonge
Copy link
Contributor

artonge commented Nov 21, 2022

Needs compilation and DCO

@PVince81
Copy link
Member

@TSI-kavitasonawane thanks. To move forward, you also need the following:

  • make sure your commits respect the DCO, see https://github.com/nextcloud/server/pull/35299/checks?check_run_id=9614619584 for how to sign off commits
  • run these command locally before checking in: make dev-setup && make build-js-production && npm run sass && npm run sass:icons, then check in the compiled assets. If you don't we can summon a bot that does it here after you pushed.

@TSI-kavitasonawane TSI-kavitasonawane force-pushed the nmcpr/1416-prevents-selection-of-encrypted-folders branch from a13b76f to 95e61ef Compare November 22, 2022 10:27
@TSI-kavitasonawane
Copy link
Contributor Author

@TSI-kavitasonawane thanks. To move forward, you also need the following:

  • make sure your commits respect the DCO, see https://github.com/nextcloud/server/pull/35299/checks?check_run_id=9614619584 for how to sign off commits
  • run these command locally before checking in: make dev-setup && make build-js-production && npm run sass && npm run sass:icons, then check in the compiled assets. If you don't we can summon a bot that does it here after you pushed.

@PVince81
I have updated commits with respect to DCO.
Also done compilation and added compiled files as well. Please check it.
Thanks

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and commit looks good, now waiting for CI 👍

@PVince81 PVince81 merged commit 0b21a9a into nextcloud:master Nov 22, 2022
@welcome
Copy link

welcome bot commented Nov 22, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@PVince81
Copy link
Member

/backport to stable25

@PVince81
Copy link
Member

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@PVince81
Copy link
Member

stable24: #35349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants