Filelist:-Deselecting all files checkboxes within cells of encrypted …#35167
Filelist:-Deselecting all files checkboxes within cells of encrypted …#35167TSI-kavitasonawane wants to merge 6 commits intonextcloud:masterfrom
Conversation
…folder Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
There was a problem hiding this comment.
Overall, I do not think that a user would expect this behavior.
Just to be sure that I understand properly: this prevents the selection of encrypted folders when clicking on the "Select all" checkbox. And the goal is to keep more actions in the action menu.
Maybe @jancborchardt or @nimishavijay for a designer opinion
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
|
@TSI-kavitasonawane which are the specific actions which are removed from the menu if encrypted folders are selected too? But yeah, I would agree with this change if it messes with selecting all too much. |
@jancborchardt
Please find attached screenshots with selection of encryted folders and without selection of encryted folders. |
…older Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
PVince81
left a comment
There was a problem hiding this comment.
Code looks fine so far.
@TSI-kavitasonawane please confirm that you have tested the "select all" scenario where the encrypted files are at the bottom of the list (ex: on page 3 before scrolling) and that when you scroll down the checkbox doesn't appear ?
Because when scrolling down, items are rendered dynamically on the 2nd page, etc.
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
@PVince81 |
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
|
This need compilation and DCO |
|
I have renamed this branch with same changes to follow the new branch naming-conventions. New PR - #35299 |


…folder
Signed-off-by: Kavita Sonawane kavita.sonawane@t-systems.com
Problem statement: In the File List view the encrypted folder should not get selected when we use select all option. If the encrypted folder gets selected the options in actions gets compromised.
To resolve this issue we applied below solution:
After selecting all files in file list we will disable the clickable area for the checkbox within a cells of an encrypted folder.