Conversation
skjnldsv
approved these changes
May 17, 2022
Contributor
Author
|
I don't know how to fix this error 😕 |
come-nc
approved these changes
May 17, 2022
Contributor
come-nc
left a comment
There was a problem hiding this comment.
Should be an occ command no?
apps/dav/bin/chunkperf.php
Outdated
| * @return array | ||
| */ | ||
| function request($client, $method, $uploadUrl, $data = null, $headers = []) { | ||
| function request($client, $method, $uploadUrl, $data = null, $headers = []): array { |
Contributor
There was a problem hiding this comment.
Suggested change
| function request($client, $method, $uploadUrl, $data = null, $headers = []): array { | |
| function request(Client $client, string $method, string $uploadUrl, $data = null, array $headers = []): array { |
Contributor
Author
Maybe ;) It seems the script was added with 72f5c53 as helper to test and benchmark chunked uploads. It's broken for quite some time (because the path to 3rdparty autoloader was wrong). I have really no idea about the psalm warnings. Maybe it's easier to just remove it 🤔 |
Member
|
I would remove it completely (see #31943 (comment)) |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
24dcfcf to
33cd7bf
Compare
MichaIng
approved these changes
May 18, 2022
CarlSchwan
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this gem in our psalm-baseline.xml today 🤣
It's a script to upload a file in chunks to Nextcloud.
Fixed the psalm warning, the autoloader import and added a usage message.Decided to remove the script.