Skip to content

Cleanup dav#31943

Merged
CarlSchwan merged 2 commits intomasterfrom
dav-cleanup
May 17, 2022
Merged

Cleanup dav#31943
CarlSchwan merged 2 commits intomasterfrom
dav-cleanup

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Apr 12, 2022

  • Remove unused class AppEnabledPlugin
  • Add more types hinting when possible
  • Port to LoggerInterface in some places

Only merge after branching

@CarlSchwan CarlSchwan added the 2. developing Work in progress label Apr 12, 2022
@CarlSchwan CarlSchwan self-assigned this Apr 12, 2022
@CarlSchwan CarlSchwan requested a review from tcitworld as a code owner April 12, 2022 12:40
@tcitworld
Copy link
Member

tcitworld commented Apr 12, 2022

Remove unused class AppEnabledPlugin

Added by @icewind1991 in owncloud/core#9962, maybe they have opinions on this?

@CarlSchwan
Copy link
Member Author

CarlSchwan commented Apr 12, 2022

Remove unused class AppEnabledPlugin

Added by @icewind1991 in owncloud/core#9962, maybe they have opinions on this?

Looking at https://github.com/owncloud-archive/contacts/pull/563/files it seems it is about disabling caldav and the carddav endpoint when the respective apps are disabled. The usage of AppEnabledPlugin has been removed in the two apps since the carddav and caldav backend still work if the calendar and contact apps are disabled or not installed

@CarlSchwan
Copy link
Member Author

CarlSchwan commented Apr 12, 2022 •
edited
Loading

  • todo fix tests

@tcitworld
Copy link
Member

tcitworld commented Apr 12, 2022

Ah yes this is very very old. 🕸️ 🧹

MichaIng
MichaIng reviewed Apr 17, 2022
View reviewed changes
@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
@CarlSchwan CarlSchwan mentioned this pull request Apr 25, 2022
Closed
24 tasks
miaulalala
miaulalala approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boy those typed properties sure are nice 😍

CarlSchwan
CarlSchwan commented May 2, 2022
View reviewed changes
@CarlSchwan
Cleanup dav
829490a 
- Remove unused class AppEnabledPlugin
- Add more type hinting when possible

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
Copy link
Member Author

CarlSchwan commented May 5, 2022

Also noticed that apps/dav/bin/chunkperf.php is broken (require path is not correct), might be a good idea to remove it completely?

@CarlSchwan CarlSchwan force-pushed the dav-cleanup branch 2 times, most recently from fbd2094 to 1d283fc Compare May 6, 2022 13:13
@CarlSchwan CarlSchwan requested a review from miaulalala May 6, 2022 13:14
come-nc
come-nc reviewed May 12, 2022
View reviewed changes
come-nc
come-nc reviewed May 12, 2022
View reviewed changes
come-nc
come-nc reviewed May 12, 2022
View reviewed changes
come-nc
come-nc reviewed May 12, 2022
View reviewed changes
@CarlSchwan
Fix more psalm issues
f7be761 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan mentioned this pull request May 17, 2022
Merged
@CarlSchwan CarlSchwan requested a review from kesselb May 17, 2022 12:59
@CarlSchwan CarlSchwan merged commit 07c9bf1 into master May 17, 2022
@CarlSchwan CarlSchwan deleted the dav-cleanup branch May 17, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaIng MichaIng MichaIng left review comments

@come-nc come-nc come-nc approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@CarlSchwan CarlSchwan

Labels

2. developing Work in progress

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

6 participants

@CarlSchwan @tcitworld @miaulalala @MichaIng @come-nc @blizzz