[stable19] Fix public calendars shared to circles#24447
Merged
MorrisJobke merged 2 commits intostable19from Nov 30, 2020
Merged
[stable19] Fix public calendars shared to circles#24447MorrisJobke merged 2 commits intostable19from
MorrisJobke merged 2 commits intostable19from
Conversation
as the QueryException is already catched inside circleToPrincipal. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
MorrisJobke
approved these changes
Nov 30, 2020
skjnldsv
approved these changes
Nov 30, 2020
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 36067: failuremysql8.0-php7.2Show full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #23652