Fix public calendars shared to circles#23652
Merged
MorrisJobke merged 2 commits intomasterfrom Nov 30, 2020
Merged
Conversation
Contributor
Author
|
I don't like this approach. The knowledge if an app is able to handle a request without a user session should be in the app itself and not here. But the circles api defines that either a Circle object is return or an exception. Unfortunately we only catch |
Member
|
Please rebase :) |
|
is there any progress about the review process? |
juliusknorr
approved these changes
Nov 25, 2020
tcitworld
approved these changes
Nov 26, 2020
as the QueryException is already catched inside circleToPrincipal. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
ac8939a to
35098a9
Compare
skjnldsv
approved these changes
Nov 26, 2020
Member
|
/backport to stable20 |
Member
|
/backport to stable19 |
Member
|
/backport to stable18 |
|
The backport to stable18 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/circles#508
TypeError: Argument 2 passed to OCA\Circles\Db\CirclesRequest::getCircle() must be of the type string, null given, called in /var/www/html/apps/circles/lib/Service/CirclesService.php on line 271It's not possible to fetch the principal from the circles app without a valid user session.
ca279f3 Update outdated phpdoc
ac8939a Fix
How to test: