Merged
Conversation
042c2d8 to
fc9ae94
Compare
Signed-off-by: Christoph Wurst <[email protected]>
fc9ae94 to
ae0a496
Compare
Member
Author
|
🚀 🙏 🤯 |
skjnldsv
reviewed
Nov 13, 2020
| if (tabView.id) { | ||
| OCA.Files.Sidebar.registerTab(new OCA.Files.Sidebar.Tab({ | ||
| id: tabView.id, | ||
| id: tabView.id, |
skjnldsv
reviewed
Nov 13, 2020
| * @returns {String} locale string | ||
| */ | ||
| export const getLocale = () => $('html').data('locale') | ||
| export const getLocale = () => $('html').data('locale') ?? 'en' |
skjnldsv
reviewed
Nov 13, 2020
| actions.forEach(function(action) { | ||
| const template = entryTemplate | ||
| $list.find('ul').append(template(action)) | ||
| $list.find('ul').append(entryTemplate(action)) |
ChristophWurst
commented
Nov 13, 2020
| $list.find('ul').append(entryTemplate(action)) | ||
| }) | ||
|
|
||
| $div.trigger('load') |
Member
Author
There was a problem hiding this comment.
FYI needed so a test can await the async operation to be done.
ChristophWurst
commented
Nov 13, 2020
| title, | ||
| })) | ||
|
|
||
| $div.trigger('loaderror', jqXHR) |
Member
Author
There was a problem hiding this comment.
Same. Just see the updated spec code :)
skjnldsv
approved these changes
Nov 13, 2020
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Tried a few thing, clicking around, files contactsmenu,settings, old legacy areas, no errors, works fine! 👍
Awesome job!!
GretaD
approved these changes
Nov 13, 2020
Contributor
GretaD
left a comment
There was a problem hiding this comment.
I also couldnt find anything that is broken because of this PR 👍
PVince81
reviewed
Nov 13, 2020
Member
PVince81
left a comment
There was a problem hiding this comment.
Did a quick clicking around through the files app, shares, public shares and settings and it looked fine
Member
|
Nice! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #23099 but in a smaller step.
📜 https://jquery.com/upgrade-guide/3.0
3.0 didn't work because of an UMD issue jquery/jquery-migrate#273, so I'm trying 3.1. Locally things still work.
is(':visible')behaves different with jQuery 3. I couldn't ge t one of the tests to pass, but it's a component that will hopefully soon be replaced by Vue so I just dropped the one test. https://api.jquery.com/visible-selector/ for more info..selectorwas deprecated in 1.9 and removed in 3. I removed an assertion that relied on that.doneand have the test framework await the results