Bump jquery from 2.2.4 to 3.5.0 #23099
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Did a quick check, clicked around a bit and didn't found any huge issue yet. LDAP wizard still seems to work. So I'd say we get this in early for 21 now :) |
juliusknorr
approved these changes
Sep 30, 2020
Member
|
Failures might be related, need to check again. |
ChristophWurst
approved these changes
Sep 30, 2020
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Line 103 in 54f4ede
Let's do this 🚀
skjnldsv
approved these changes
Sep 30, 2020
Contributor
|
Please make sure to update to 3.5.1, not to 3.5.0 (which introduced a regression, cf. https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/) |
Member
|
@dependabot-bot recreate |
8942214 to
af09d0f
Compare
Member
|
mmm why is dependabot not bumping it to 3.5.1 ? |
Member
|
@dependabot rebase |
af09d0f to
eea3973
Compare
eea3973 to
6ae36c2
Compare
Member
|
/compile amend / |
Member
|
Manually bumped to 3.5.1 now, not sure why dependabot was not picking that one up. Let's see if CI is also happy with that. I couldn't see any major breaking with 3.5.1 as well |
6ae36c2 to
565019c
Compare
Member
I think because of the security bump. I thinks we're fixing the v2.2 flaws with 3.5. |
Member
|
@dependabot recreate |
565019c to
45fd0ea
Compare
Member
|
/compile amend / |
Member
No it's because the version is fixed in the package.json |
Bumps [jquery](https://github.com/jquery/jquery) from 2.2.4 to 3.5.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](jquery/jquery@2.2.4...3.5.0) Signed-off-by: dependabot[bot] <[email protected]>
45fd0ea to
5f50ef0
Compare
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 35054: failurejsunitShow full logacceptance-app-files-sharing
Show full log |
Member
|
Lots of jsunit issues |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps jquery from 2.2.4 to 3.5.0.
Release notes
Sourced from jquery's releases.
Commits
7a0a8503.5.08570a08Release: Update AUTHORS.txtda3dd85Ajax: Do not execute scripts for unsuccessful HTTP responses065143cAjax: Overwrite s.contentType with content-type header value, if any1a4f10dTests: Blacklist one focusin test in IE9e15d6bEvent: Use only one focusin/out handler per matching window & document966a709Manipulation: Skip the select wrapper for <option> outside of IE 91d61fd9Manipulation: Make jQuery.htmlPrefilter an identity function04bf577Selector: Update Sizzle from 2.3.4 to 2.3.57506c9cBuild: Resolve Travis config warningsMaintainer changes
This version was pushed to npm by mgol, a new releaser for jquery since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.