Incorrect repeat counts for OBX-8/9/10/16 in v2.4

[stormcrow79]

NHapi.Model.V24.OBX has incorrect repeat counts for the following fields:

• OBX-8 Abnormal Flags is 1, should be 5
• OBX-9 Probability is 5, should be 1
• OBX-10 Nature of Abnormal Test is 1, should be unlimited
• OBX-16 Responsible Observer is 1, should be unlimited

NHapi 2.5.0.6 to 3.1.0 throw HL7Exception from LegacyPipeParser.Parse for a segment that is valid by the spec:

OBX|1|FT|ALLERG^Allergie^MOLIS||dummy report|||A~B~C~D~E|0.5|X~Y~Z|C|||20030331053409||A11^SMITH^JOHN~B22^JONES^FRED~C33^BEAN^MARY";

NHapi 3.1.1 does not raise an exception due to changes in PR #277.

This seems to be due to a problem with the HL7 database and/or codegen affecting only v2.4 - v2.3 and v2.5 have the expected repeat count. This is similar to issue #191.

I'm happy to raise a PR for the model changes.

[milkshakeuk]

@stormcrow79 I will take a look into this.

[milkshakeuk]

@stormcrow79 I ran the query in the database and it looks like the database might be incorrect here, I will let the DB maintainer know to see if we can get a fix in to the database before we consider any PRs.

v2.4

[milkshakeuk]

@stormcrow79 seems it is an issue with the database, when I get an updated copy of the DB I should be able to generate the fix.

[stormcrow79]

Great, thanks @milkshakeuk . I've been sitting on this one since Sep 2020 when 2.x was unmaintained!

[stormcrow79]

hey @milkshakeuk what's the release cadence for the db?

[milkshakeuk]

@stormcrow79 good question, I think its probably ready when its ready - but I will check back with Frank!

[milkshakeuk]

@stormcrow79 sorry for the long delay on this, I will check in with Frank probably in the new year now.

[stormcrow79]

@milkshakeuk thanks for the update - happy holidays!

[milkshakeuk]

@stormcrow79 okay got the latest DB, will look to create a PR for this soon.