Skip to content

Port planning scene ros api tutorial#74

Merged
MarqRazz merged 11 commits into
moveit:mainfrom
vatanaksoytezer:feauture/planning_scene_ros_api_tutorial
Apr 21, 2021
Merged

Port planning scene ros api tutorial#74
MarqRazz merged 11 commits into
moveit:mainfrom
vatanaksoytezer:feauture/planning_scene_ros_api_tutorial

Conversation

@vatanaksoytezer

Copy link
Copy Markdown
Contributor

@vatanaksoytezer

Copy link
Copy Markdown
Contributor Author

Also there seems something wrong with ros2 run moveit_ros_planning moveit_print_planning_scene_info. Which gives me:

[INFO] [1618491970.223003091] [print_planning_scene_info]: Getting planning scene info to print
[INFO] [1618491970.223125481] [moveit_rdf_loader.rdf_loader]: Robot model parameter not found! Did you remap 'robot_description'?
[ERROR] [1618491970.227218950] [moveit_ros.planning_scene_monitor.planning_scene_monitor]: Robot model not loaded
[ERROR] [1618491970.227438829] [print_planning_scene_info]: Planning scene not configured

@MarqRazz MarqRazz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @vatanaksoytezer.

Is there a fix/issue open for getting moveit_print_planning_scene_info to work?

planning_scene_diff_publisher->publish(planning_scene);

visual_tools.prompt("Press 'next' in the RvizVisualToolsGui window to continue the demo");
prompt("Press 'next' in the RvizVisualToolsGui window to continue the demo");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to change the prompt prints to not include RvizVisualToolsGui?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were actually not working as intended for me, so I used the normal function one.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time I checked rviz_visual_tools GUI had not been ported to ROS2.

In the other tutorials I ported I commented out the visual_tools.prompt and added my own to make it easy to re-enable when it gets added back in. It's up to you if you want to do the same approach here...

prompt("Press 'Enter' to start the demo");
/* visual_tools.prompt("Press 'next' in the RvizVisualToolsGui window to start the demo"); */

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure, I can make it that way.

Comment thread doc/planning_scene_ros_api/planning_scene_ros_api_tutorial.rst
Comment thread doc/planning_scene_ros_api/planning_scene_ros_api_tutorial.rst Outdated
Co-authored-by: Marq Rasmussen <marq.razz@gmail.com>
@vatanaksoytezer

vatanaksoytezer commented Apr 20, 2021

Copy link
Copy Markdown
Contributor Author

Is there a fix/issue open for getting moveit_print_planning_scene_info to work?

Yeah, I've talked this with @JafarAbdi , I wrote the todo for it but I forgot to open up the issue. Will open today. He has mentioned he knew what the problem is and will fix it when he has some spare time to work on that.

See #76.

@MarqRazz MarqRazz merged commit 64320dd into moveit:main Apr 21, 2021
@vatanaksoytezer vatanaksoytezer linked an issue Apr 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port "Planning Scene ROS API" tutorial

3 participants