This repository was archived by the owner on Aug 8, 2024. It is now read-only.
Add types supporting C# 8.0 Ranges.#250
Merged
Merged
Conversation
* Expose Index and Range types * Address Review Comments * Address more feedback * Addressing more comments Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> (cherry picked from commit b730b3c)
* Reduce allocation in Index/Range.ToString * Address PR feedback Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> (cherry picked from commit ceee48b)
* Expose Index and Range with adding tests * More tests and more exposed APIs * More changes * address feedback * Fix ApiCompat break * Fix UAPAOT app compat (cherry picked from commit 75a6b03)
This was referenced Feb 7, 2019
Member
|
Does this change also include dotnet/coreclr#22331 ? |
Author
|
I cherry-picked the commits from |
* Index and Range updates * Address @mikedn feedback * Address Feedback * more feedback * Use Deconstruct in Range.GetOffsetAndLength * Rename GetArrayRange to GetSubArray * Temporary disable the old Corefx Range tests * Return back the TimeSpan test disabling * Fix Range jit test * Exclude the jit test * revert the changes in the jit Range test * Address Suggested Feedback Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> (cherry picked from commit b0b1617)
Author
|
It looks like we're still missing dotnet#35003 or something like this? Tests are currently failing with lots of |
Author
|
Looks like this is going to land as part of dotnet#35207. |
…-4e11-961e-78e7628e8c2c Update dependencies from dotnet/coreclr (cherry picked from commit 0998699)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.