This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Expose Index and Range with adding tests#33352
Merged
Merged
Conversation
Member
Author
|
This is pending on dotnet/coreclr#20899 |
Member
Author
stephentoub
reviewed
Nov 10, 2018
stephentoub
reviewed
Nov 10, 2018
stephentoub
approved these changes
Nov 10, 2018
Joe4evr
reviewed
Nov 10, 2018
| Assert.Equal(span1[new Index(2, fromEnd: false)], span1[new Index(span.Length - 2, fromEnd: true)]); | ||
|
|
||
| Assert.Throws<IndexOutOfRangeException>(() => | ||
| new Span<char>(new char [] { 'H', 'e', 'l', 'l', 'o'})[new Index(0, fromEnd: true)]); |
There was a problem hiding this comment.
I still don't like this semantic in the slightest. It's like going backwards to VB6-esque programming models.
Member
|
@dotnet-bot test this please |
Member
Author
|
I am looking at the failure in UWP. properly I'll need to exclude the new APIs from the App compat checks. |
Member
Author
|
The failed CI case is tracked by https://github.com/dotnet/corefx/issues/33389 |
baulig
pushed a commit
to mono/corefx
that referenced
this pull request
Feb 7, 2019
* Expose Index and Range with adding tests * More tests and more exposed APIs * More changes * address feedback * Fix ApiCompat break * Fix UAPAOT app compat (cherry picked from commit 75a6b03)
marek-safar
pushed a commit
to mono/corefx
that referenced
this pull request
Feb 12, 2019
* Expose Index and Range with adding tests * More tests and more exposed APIs * More changes * address feedback * Fix ApiCompat break * Fix UAPAOT app compat (cherry picked from commit 75a6b03)
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Expose Index and Range with adding tests * More tests and more exposed APIs * More changes * address feedback * Fix ApiCompat break * Fix UAPAOT app compat Commit migrated from dotnet/corefx@75a6b03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.