add review, approval info and linkify

preview-src/index.css

@@ -178,7 +178,8 @@ body .comment-container .review-comment-header {
 
 body .comment-container .review-comment-header > span,
 body .comment-container .review-comment-header > a,
-body .commit .commit-message > a {
+body .commit .commit-message > a,
+body .merged .merged-message > a {
 	margin-right: 4px;
 }
 
@@ -355,12 +356,13 @@ body .overview-title .button-group button {
 	fill: var(--vscode-foreground);
 }
 
-.comment-container.commit {
+.comment-container.commit,
+.comment-container.merged {
 	padding-left: 16px;
 	box-sizing: border-box
 }
 
-.commit, .review {
+.commit, .review, .merged {
 	display: flex;
 	width: 100%;
 	border: none;
@@ -373,24 +375,28 @@ body .overview-title .button-group button {
 	padding: 4px 0;
 }
 
-.commit .commit-message {
+.commit .commit-message,
+.merged .merged-message {
 	display: flex;
 	align-items: center;
 	line-height: 18px;
 	overflow: hidden;
 }
 
-.commit .commit-message .avatar-container {
+.commit .commit-message .avatar-container,
+.merged .merged-message .avatar-container {
 	margin-right: 4px;
 	flex-shrink: 0;
 }
 
-.commit .avatar-container .avatar {
+.commit .avatar-container .avatar,
+.merged .avatar-container .avatar {
 	width: 18px;
 	height: 18px;
 }
 
-.commit .commit-message .message {
+.commit .commit-message .message,
+.merged .merged-message .message {
 	overflow: inherit;
 	text-overflow: ellipsis;
 	white-space: nowrap;
@@ -400,6 +406,19 @@ body .overview-title .button-group button {
 	margin-left: auto;
 }
 
+.merged .merged-message .message,
+.merged .inline-sha {
+	margin: 0 4px 0 0;
+}
+
+.merged svg {
+    width: 14px;
+    height: auto;
+    margin-right: 8px;
+    flex-shrink: 0;
+    fill: var(--vscode-foreground);
+}
+
 .details {
 	display: flex;
 	flex-direction: column;

preview-src/pullRequestOverviewRenderer.ts

@@ -4,14 +4,15 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { dateFromNow } from '../src/common/utils';
-import { TimelineEvent, CommitEvent, ReviewEvent, CommentEvent, isCommentEvent, isReviewEvent, isCommitEvent } from '../src/common/timelineEvent';
+import { TimelineEvent, CommitEvent, ReviewEvent, CommentEvent, isCommentEvent, isReviewEvent, isCommitEvent, isMergedEvent, MergedEvent } from '../src/common/timelineEvent';
 import { PullRequestStateEnum } from '../src/github/interface';
 import md from './mdRenderer';
 import { MessageHandler } from './message';
 import { getState, updateState, PullRequest } from './cache';
 import { Comment } from '../src/common/comment';
 
 const commitIconSvg = require('../resources/icons/commit_icon.svg');
+const mergeIconSvg = require('../resources/icons/merge_icon.svg');
 const editIcon = require('../resources/icons/edit.svg');
 const deleteIcon = require('../resources/icons/delete.svg');
 const checkIcon = require('../resources/icons/check.svg');
@@ -689,6 +690,50 @@ export function renderCommit(timelineEvent: CommitEvent): HTMLElement {
 	return commentContainer;
 }
 
+export function renderMergedEvent(timelineEvent: MergedEvent): HTMLElement {
+	const shaShort = timelineEvent.sha.substring(0, 7);
+
+	const mergedMessageContainer: HTMLDivElement = document.createElement('div');
+	mergedMessageContainer.classList.add('comment-container', 'merged');
+	const mergedMessage: HTMLDivElement = document.createElement('div');
+	mergedMessage.className = 'merged-message';
+	mergedMessage.insertAdjacentHTML('beforeend', mergeIconSvg);
+
+	const userIcon = renderUserIcon(timelineEvent.user.url, timelineEvent.user.avatarUrl);
+	mergedMessage.appendChild(userIcon);
+
+	const login: HTMLAnchorElement = document.createElement('a');
+	login.className = 'author';
+	login.href = timelineEvent.user.url;
+	login.textContent = timelineEvent.user.login!;
+	mergedMessage.appendChild(login);
+
+	const message: HTMLSpanElement = document.createElement('span');
+	message.className = 'message';
+	message.textContent = 'merged commit';
+	mergedMessage.appendChild(message);
+
+	const sha: HTMLAnchorElement = document.createElement('a');
+	sha.className = 'inline-sha';
+	sha.href = timelineEvent.commitUrl;
+	sha.textContent = shaShort;
+	mergedMessage.appendChild(sha);
+
+	const ref: HTMLSpanElement = document.createElement('span');
+	ref.className = 'message';
+	ref.textContent = `into ${timelineEvent.mergeRef}`;
+	mergedMessage.appendChild(ref);
+
+	const timestamp: HTMLAnchorElement = document.createElement('a');
+	timestamp.className = 'timestamp';
+	timestamp.href = timelineEvent.url;
+	timestamp.textContent = dateFromNow(timelineEvent.createdAt);
+	mergedMessage.appendChild(timestamp);
+
+	mergedMessageContainer.appendChild(mergedMessage);
+	return mergedMessageContainer;
+}
+
 function getDiffChangeClass(type: DiffChangeType) {
 	switch (type) {
 		case DiffChangeType.Add:
@@ -756,6 +801,15 @@ class ReviewNode {
 		userLogin.href = this._review.user.url;
 		userLogin.textContent = this._review.user.login;
 
+		commentHeader.appendChild(userIcon);
+		commentHeader.appendChild(userLogin);
+
+		if (this._review.authorAssociation && this._review.authorAssociation !== 'NONE') {
+			const authorAssociation: HTMLSpanElement = document.createElement('span');
+			authorAssociation.textContent = `(${this._review.authorAssociation.toLocaleLowerCase()})`;
+			commentHeader.appendChild(authorAssociation);
+		}
+
 		const reviewState = document.createElement('span');
 		switch (this._review.state.toLowerCase()) {
 			case 'approved':
@@ -781,8 +835,6 @@ class ReviewNode {
 			timestamp.classList.add('pending');
 		}
 
-		commentHeader.appendChild(userIcon);
-		commentHeader.appendChild(userLogin);
 		commentHeader.appendChild(reviewState);
 		commentHeader.appendChild(timestamp);
 
@@ -798,7 +850,7 @@ class ReviewNode {
 		const reviewBody: HTMLDivElement = document.createElement('div');
 		reviewBody.className = 'review-body';
 		if (this._review.body) {
-			reviewBody.innerHTML = md.render(emoji.emojify(this._review.body));
+			reviewBody.innerHTML = this._review.bodyHTML ? this._review.bodyHTML : md.render(emoji.emojify(this._review.body));
 			reviewCommentContainer.appendChild(reviewBody);
 		}
 
@@ -942,6 +994,10 @@ export function renderTimelineEvent(timelineEvent: TimelineEvent, messageHandler
 		return renderComment(timelineEvent, messageHandler);
 	}
 
+	if (isMergedEvent(timelineEvent)) {
+		return renderMergedEvent(timelineEvent);
+	}
+
 	return undefined;
 }
 

src/common/timelineEvent.ts

@@ -38,36 +38,63 @@ export interface CommentEvent {
 }
 
 export interface ReviewEvent {
-	event: string;
+	event: EventType;
 	comments: Comment[];
 	submittedAt: string;
 	body: string;
+	bodyHTML?: string;
 	htmlUrl: string;
 	user: IAccount;
+	authorAssociation: string;
 	state: string;
 	id: number;
 }
 
 export interface CommitEvent {
 	author: IAccount;
-	event: string;
+	event: EventType;
 	sha: string;
 	url: string;
 	htmlUrl: string;
 	message: string;
 	bodyHTML?: string;
 }
 
-export type TimelineEvent = CommitEvent | ReviewEvent | CommentEvent;
+export interface MergedEvent {
+	graphNodeId: string;
+	user: IAccount;
+	createdAt: string;
+	mergeRef: string;
+	sha: string;
+	commitUrl: string;
+	event: EventType;
+	url: string;
+}
+
+export interface AssignEvent {
+	event: EventType;
+	user: IAccount;
+	actor: IAccount;
+}
+
+export type TimelineEvent = CommitEvent | ReviewEvent | CommentEvent | MergedEvent | AssignEvent;
 
 export function isReviewEvent(event: TimelineEvent): event is ReviewEvent {
-	return Number(event.event) === EventType.Reviewed;
+	return event.event === EventType.Reviewed;
 }
 
 export function isCommitEvent(event: TimelineEvent): event is CommitEvent {
-	return Number(event.event) === EventType.Committed;
+	return event.event === EventType.Committed;
 }
 
 export function isCommentEvent(event: TimelineEvent): event is CommentEvent {
-	return Number(event.event) === EventType.Commented;
+	return event.event === EventType.Commented;
+}
+
+export function isMergedEvent(event: TimelineEvent): event is MergedEvent {
+	return event.event === EventType.Merged;
 }
+
+export function isAssignEvent(event: TimelineEvent): event is AssignEvent {
+	return event.event === EventType.Assigned;
+}

src/github/githubRepository.ts

@@ -13,8 +13,8 @@ import { CredentialStore, GitHub } from './credentials';
 import { AuthenticationError } from '../common/authentication';
 import { QueryOptions, MutationOptions, ApolloQueryResult, NetworkStatus } from 'apollo-boost';
 import { PRDocumentCommentProvider, PRDocumentCommentProviderGraphQL } from '../view/prDocumentCommentProvider';
-import { convertRESTPullRequestToRawPullRequest } from './utils';
-import { MentionableUsersResponse } from './graphql';
+import { convertRESTPullRequestToRawPullRequest, parseGraphQLPullRequest } from './utils';
+import { PullRequestResponse, MentionableUsersResponse } from './graphql';
 const queries = require('./queries.gql');
 
 export const PULL_REQUEST_PAGE_SIZE = 20;
@@ -279,22 +279,47 @@ export class GitHubRepository implements IGitHubRepository, vscode.Disposable {
 	async getPullRequest(id: number): Promise<PullRequestModel | undefined> {
 		try {
 			Logger.debug(`Fetch pull request ${id} - enter`, GitHubRepository.ID);
-			const { octokit, remote } = await this.ensure();
-			let { data } = await octokit.pullRequests.get({
+			const { octokit, query, remote } = await this.ensure();
+			let prsResult = await octokit.pullRequests.get({
 				owner: remote.owner,
 				repo: remote.repositoryName,
 				number: id
 			});
 			Logger.debug(`Fetch pull request ${id} - done`, GitHubRepository.ID);
 
-			if (!data.head.repo) {
+			if (!prsResult.data.head.repo) {
 				Logger.appendLine('The remote branch for this PR was already deleted.', GitHubRepository.ID);
 				return;
 			}
 
-			let item = convertRESTPullRequestToRawPullRequest(data);
+			if (this.supportsGraphQl()) {
+				const { data } = await query<PullRequestResponse>({
+					query: queries.PullRequest,
+					variables: {
+						owner: remote.owner,
+						name: remote.repositoryName,
+						number: id
+					}
+				});
 
-			return new PullRequestModel(this, remote, item);
+				Logger.debug(`Fetch pull request ${id} - done`, GitHubRepository.ID);
+				return new PullRequestModel(this, remote, parseGraphQLPullRequest(data));
+			} else {
+				let { data } = await octokit.pullRequests.get({
+					owner: remote.owner,
+					repo: remote.repositoryName,
+					number: id
+				});
+				Logger.debug(`Fetch pull request ${id} - done`, GitHubRepository.ID);
+
+				if (!data.head.repo) {
+					Logger.appendLine('The remote branch for this PR was already deleted.', GitHubRepository.ID);
+					return;
+				}
+
+				let item = convertRESTPullRequestToRawPullRequest(data);
+				return new PullRequestModel(this, remote, item);
+			}
 		} catch (e) {
 			Logger.appendLine(`GithubRepository> Unable to fetch PR: ${e}`);
 			return;