add review, approval info and linkify #831
Conversation
| createdAt: graphQLPullRequest.createdAt, | ||
| updatedAt: graphQLPullRequest.updatedAt, | ||
| head: { | ||
| label: graphQLPullRequest.headRef.name, |
There was a problem hiding this comment.
is it possible for headRef or baseRef to be undefined, if they've been deleted?
There was a problem hiding this comment.
It can be null based on the schema, I'd love to use the generated typings with strict null checks ;)
src/github/utils.ts
Outdated
| }; | ||
| } | ||
|
|
||
| export function parseGraphQLTimelineEvents(events: any[]): TimelineEvent[] { |
There was a problem hiding this comment.
It would be good to replace this any with the types from graphql.ts
| userLogin.textContent = this._review.user.login; | ||
|
|
||
| const authorAssociation: HTMLSpanElement = document.createElement('span'); | ||
| authorAssociation.textContent = `(${this._review.authorAssociation.toLocaleLowerCase()})`; |
There was a problem hiding this comment.
authorAssociation seems to be undefined when using the REST API. Also, when the authorAssociation is none, I think we shouldn't render it
| } | ||
|
|
||
| export function convertRESTTimelineEvents(events: any[]): TimelineEvent[] { | ||
| export function convertRESTTimelineEvents(events: any[]): Common.TimelineEvent[] { |
There was a problem hiding this comment.
if possible let's also replace any with a real type here, avatar_url isn't being converted to avatarUrl
|
Do you get the HTML directly from GitHub or do some conversions? Microsoft/vscode#xyz should also work |
|
@Tyriar we didn't do anything more if it's from github.com |
Add more timeline event info
Merge Event
Review Event Author Association
Linkify
