Skip to content

Fix Assert.That to not evaluate expression twice (re-opens #6699) #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 20 commits into from
May 19, 2026
Merged

Fix Assert.That to not evaluate expression twice (re-opens #6699) #8307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
70bf6ab
Fix double evaluation
Evangelink Oct 8, 2025
d6f4d06
Cleanup
Evangelink Oct 8, 2025
7c7b517
Apply suggestion from @Evangelink
Evangelink Oct 8, 2025
811a90a
tests
nohwnd Oct 8, 2025
b086596
Merge branch 'dev/amauryleve/assert-that' of https://github.com/micro…
nohwnd Oct 8, 2025
eeced5e
Address some comments
Evangelink Nov 25, 2025
763edb8
Merge branch 'main' into dev/amauryleve/assert-that
Evangelink Nov 25, 2025
721b339
Fixes
Evangelink Nov 25, 2025
67e91f9
Merge branch 'main' into dev/amauryleve/assert-that
Copilot May 17, 2026
9889353
Merge origin/main and resolve conflicts
Copilot May 18, 2026
e5dca55
Fix AreAllDistinct comparer display
Copilot May 18, 2026
a52a02e
Merge branch 'main' into dev/amauryleve/assert-that
Evangelink May 18, 2026
7a42797
Optimize Assert.That passing path evaluation
Copilot May 18, 2026
e7854ab
Refine Assert.That fast-path side-effect detection
Copilot May 18, 2026
fe240ac
Deduplicate Assert.That cache initialization
Copilot May 18, 2026
82f9b22
Polish Assert.That fast-path comment
Copilot May 18, 2026
5c6e4a1
Add Assert.That fast-path and side-effect detection tests
Copilot May 18, 2026
5775de2
Skip intermediate method-call receivers when walking member chains
Copilot May 18, 2026
4c51675
Address Assert.That review feedback: short-circuit semantics, Quote, …
Evangelink May 19, 2026
1d6d948
Merge origin/main and resolve conflicts
Copilot May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,258 changes: 829 additions & 429 deletions src/TestFramework/TestFramework/Assertions/Assert.That.cs
View file
Open in desktop

Large diffs are not rendered by default.

57 changes: 30 additions & 27 deletions src/TestFramework/TestFramework/Resources/FrameworkMessages.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<root>
<!--
Microsoft ResX Schema
<!--
Microsoft ResX Schema

Version 2.0
The primary goals of this format is to allow a simple XML format
that is mostly human readable. The generation and parsing of the
various data types are done through the TypeConverter classes

The primary goals of this format is to allow a simple XML format
that is mostly human readable. The generation and parsing of the
various data types are done through the TypeConverter classes
associated with the data types.

Example:

... ado.net/XML headers & schema ...
<resheader name="resmimetype">text/microsoft-resx</resheader>
<resheader name="version">2.0</resheader>
Expand All @@ -26,36 +26,36 @@
<value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
<comment>This is a comment</comment>
</data>
There are any number of "resheader" rows that contain simple

There are any number of "resheader" rows that contain simple
name/value pairs.
Each data row contains a name, and value. The row also contains a
type or mimetype. Type corresponds to a .NET class that support
text/value conversion through the TypeConverter architecture.
Classes that don't support this are serialized and stored with the

Each data row contains a name, and value. The row also contains a
type or mimetype. Type corresponds to a .NET class that support
text/value conversion through the TypeConverter architecture.
Classes that don't support this are serialized and stored with the
mimetype set.
The mimetype is used for serialized objects, and tells the
ResXResourceReader how to depersist the object. This is currently not

The mimetype is used for serialized objects, and tells the
ResXResourceReader how to depersist the object. This is currently not
extensible. For a given mimetype the value must be set accordingly:
Note - application/x-microsoft.net.object.binary.base64 is the format
that the ResXResourceWriter will generate, however the reader can

Note - application/x-microsoft.net.object.binary.base64 is the format
that the ResXResourceWriter will generate, however the reader can
read any of the formats listed below.

mimetype: application/x-microsoft.net.object.binary.base64
value : The object must be serialized with
value : The object must be serialized with
: System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
: and then encoded with base64 encoding.

mimetype: application/x-microsoft.net.object.soap.base64
value : The object must be serialized with
value : The object must be serialized with
: System.Runtime.Serialization.Formatters.Soap.SoapFormatter
: and then encoded with base64 encoding.

mimetype: application/x-microsoft.net.object.bytearray.base64
value : The object must be serialized into a byte array
value : The object must be serialized into a byte array
: using a System.ComponentModel.TypeConverter
: and then encoded with base64 encoding.
-->
Expand Down Expand Up @@ -454,6 +454,9 @@ Actual: {2}</value>
<data name="IsInRangeMaxValueMustBeGreaterThanOrEqualMinValue" xml:space="preserve">
<value>The maximum value must be greater than or equal to the minimum value.</value>
</data>
<data name="AssertThatFailedToEvaluate" xml:space="preserve">
<value>&lt;Failed to evaluate&gt;</value>
</data>
<data name="AssertScopeFailure" xml:space="preserve">
<value>{0} assertion(s) failed within the assert scope.</value>
<comment>{0} is the number of assertion failures collected in the scope.</comment>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Podrobnosti:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">Zpráva: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Details:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">Meldung: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Detalles:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">Mensaje: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Détails :</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">Message : {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Dettagli:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">Messaggio: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">詳細:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">メッセージ: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">세부 정보:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">메시지: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Szczegóły:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">Komunikat: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Detalhes:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">Mensagem: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Подробности:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">Сообщение: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">Ayrıntılar:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">İleti: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">详细信息:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">消息: {0}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@
<target state="translated">詳細資料:</target>
<note />
</trans-unit>
<trans-unit id="AssertThatFailedToEvaluate">
<source>&lt;Failed to evaluate&gt;</source>
<target state="new">&lt;Failed to evaluate&gt;</target>
<note />
</trans-unit>
<trans-unit id="AssertThatMessageFormat">
<source>Message: {0}</source>
<target state="translated">訊息: {0}</target>
Expand Down
Loading
Loading