Skip to content

fix(test): convert resolved paths to file:// URLs for ESM on Windows #41137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yen0304 wants to merge 1 commit into from
Closed

fix(test): convert resolved paths to file:// URLs for ESM on Windows #41137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions packages/playwright/src/transform/esmLoaderSync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,19 @@ import { currentFileDepsCollector } from './compilationCache';
import { resolveHook, shouldTransform, transformHook } from './transform';
import { fileIsModule } from '../util';

export function resolve(specifier: string, context: { parentURL?: string }, nextResolve: Function) {
export function resolve(specifier: string, context: { parentURL?: string, conditions?: string[] }, nextResolve: Function) {
if (context.parentURL && context.parentURL.startsWith('file://')) {
const filename = url.fileURLToPath(context.parentURL);
const resolved = resolveHook(filename, specifier);
// Pass the resolved absolute path (not a file:// URL) to nextResolve: unlike the
// ESM-only asynchronous loader, these hooks also serve require(), whose default
// resolver rejects file:// specifiers but accepts absolute paths for both kinds.
if (resolved !== undefined)
specifier = resolved;
if (resolved !== undefined) {
// ESM resolver on Windows requires file:// URLs — absolute paths like "C:\..."
// are parsed as having URL protocol "c:". CJS resolver accepts absolute paths
// directly. Use context.conditions to pick the right form.
if (context.conditions?.includes('import'))
specifier = url.pathToFileURL(resolved).toString();
else
specifier = resolved;
}
}
const result = nextResolve(specifier, context);
if (result?.url && result.url.startsWith('file://'))
Expand Down