fix(test): convert resolved paths to file:// URLs for ESM on Windows - #41137
Closed
yen0304 wants to merge 1 commit into
Closed
fix(test): convert resolved paths to file:// URLs for ESM on Windows#41137yen0304 wants to merge 1 commit into
yen0304 wants to merge 1 commit into
Conversation
The synchronous module hooks resolve function passes absolute paths directly to nextResolve. On Windows, paths like "C:\..." are parsed as having URL protocol "c:", causing ESM resolution to fail with "Only URLs with a scheme in: file, data, and node are supported". Use context.conditions to distinguish ESM from CJS contexts and convert to file:// URLs only for ESM imports, preserving the absolute path behavior for CJS require() which rejects file:// specifiers. Fixes: microsoft#41121
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolvehook inesmLoaderSync.tspasses absolute paths directly tonextResolve. On Windows, paths likeC:\...are parsed as having URL protocolc:, breaking ESM resolution.context.conditionsto distinguish ESM (import) from CJS (require) and convert tofile://URLs only for ESM imports.Fixes #41121