Disable some of rotary embedding tests as they are failing on Win GPU CUDA - #26069
Merged
Merged
Conversation
| "^test_rotary_embedding_no_position_ids_rotary_dim", | ||
| "^test_rotary_embedding_with_interleaved_rotary_dim", | ||
| "^test_rotary_embedding_with_rotary_dim", | ||
| "^test_rotary_embedding_3d_input_expanded", |
Member
There was a problem hiding this comment.
Maybe add a comment describing why the tests are failing ? Are they broken tests ? If so, should they be tracked as an issue in the ONNX repo and linked here with a TODO on re-enabling once the fix is consumed ?
hariharans29
approved these changes
Sep 17, 2025
justinchuby
deleted the
titaiwang/disable_rotary_embedding_tests_again
branch
September 17, 2025 23:35
naomiOvad
pushed a commit
to naomiOvad/onnxruntime
that referenced
this pull request
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.