Fix CUDA 12.8+ build issues with regards to fp4 type - #26061
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes build breaks in CUDA 12.8+ Linux builds by adding #include <cuda.h> to two CUDA-specific header files before other CUDA headers are included.
- Adds cuda.h include with explanatory comment to cuda_type_conversion.h
- Adds cuda.h include with explanatory comment to cuda_common.h
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| onnxruntime/core/providers/cuda/cuda_type_conversion.h | Includes cuda.h to provide CUDA_VERSION before other CUDA headers |
| onnxruntime/core/providers/cuda/cuda_common.h | Includes cuda.h to provide CUDA_VERSION before other CUDA headers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hariharans29
marked this pull request as draft
September 17, 2025 01:24
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@hariharans29it works for cuda 13? |
Member
Author
No, CUDA 13 is not tested yet. Sorry for the mis-leading title. This is to fix CUDA 12 builds but specifically 12.8+ when the fp4 type is enabled. |
hariharans29
marked this pull request as ready for review
September 17, 2025 23:59
tianleiwu
previously approved these changes
Sep 18, 2025
tianleiwu
dismissed
their stale review
September 18, 2025 00:56
pipeline still failed. Please take a look.
Member
Author
|
@tianleiwu - The failures don't seem related to this PR.
|
tianleiwu
approved these changes
Sep 22, 2025
fs-eire
pushed a commit
that referenced
this pull request
Oct 24, 2025
### Description Fix CUDA 12.8+ build issues with regards to fp4 type ### Motivation and Context Fix CUDA 12.8+ build issues with regards to fp4 type --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
naomiOvad
pushed a commit
to naomiOvad/onnxruntime
that referenced
this pull request
Nov 2, 2025
### Description Fix CUDA 12.8+ build issues with regards to fp4 type ### Motivation and Context Fix CUDA 12.8+ build issues with regards to fp4 type --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix CUDA 12.8+ build issues with regards to fp4 type
Motivation and Context
Fix CUDA 12.8+ build issues with regards to fp4 type