Skip to content

Fix undo grouping of backspacing #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhecker merged 1 commit into from
Aug 4, 2025
Merged

Fix undo grouping of backspacing #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/buffer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2555,8 +2555,7 @@ impl TextBuffer {
self.set_cursor_internal(cursor);

// If both the last and this are a Write/Delete operation, we skip allocating a new undo history item.
if cursor_before.offset != cursor.offset
|| history_type != self.last_history_type
if history_type != self.last_history_type

@DHowett DHowett Jul 30, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm is there a risk in removing this check

@lhecker lhecker Jul 30, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if the self.cursor moves without the last_history_type being reset to "other" would break this because it would group unrelated writes/deletes.

However, the commit that introduced this in the first place does make sure to reset the last_history_type from what I can tell, so this is fine.

|| !matches!(history_type, HistoryType::Write | HistoryType::Delete)
{
self.redo_stack.clear();
Expand Down