Fix undo grouping of backspacing#590
Merged
Merged
Conversation
DHowett
reviewed
Jul 30, 2025
| // If both the last and this are a Write/Delete operation, we skip allocating a new undo history item. | ||
| if cursor_before.offset != cursor.offset | ||
| || history_type != self.last_history_type | ||
| if history_type != self.last_history_type |
Member
There was a problem hiding this comment.
hmm is there a risk in removing this check
Member
Author
There was a problem hiding this comment.
Yes, if the self.cursor moves without the last_history_type being reset to "other" would break this because it would group unrelated writes/deletes.
However, the commit that introduced this in the first place does make sure to reset the last_history_type from what I can tell, so this is fine.
DHowett
approved these changes
Aug 4, 2025
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
This regressed in 091b742.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regressed in 091b742.