Skip to content

Conversation

@alvinhochun
Copy link
Contributor

Changes include:

  • Since a partial windowsnumerics.impl.h header has been added to mingw-w64 recently, we can enable the tests that depend on it. If it is not available in the current mingw-w64 toolchain, there is an option to download a copy of it from the mingw-w64 git repo to allow these tests to run.
  • Enable some test cases of test_cpp20 and test_old for llvm-mingw. test_old in particular depends on windowsnumerics.impl.h)
  • Re-enable test code for Clang fixed by Remove low-level coroutine suspension notifications #1228.
  • Enable some test cases for llvm-mingw that crashes only when built using Clang with MSVC ABI.
  • Make some tests relying on error messages pass on non-English Windows systems.
  • Use lowercase filename when including Windows headers, which is needed for cross-building from Linux with mingw-w64.

co_await context;
}

// Not yet buildable on mingw-w64. The lambda needs to have __stdcall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this lambda has no captures, it can be converted to a normal function with __stdcall.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can work though it's not as clean as it currently is. However, the test that actually requires this code cannot be built due to missing __uuidof(IContextCallback) (which has been fixed on mingw-w64 upstream, but the current llvm-mingw 15 toolchain doesn't have the fix), so there is no harm just leaving this out for now.

@kennykerr kennykerr merged commit 921f62f into microsoft:master Nov 18, 2022
@alvinhochun alvinhochun deleted the alvin/mingw-tests branch November 19, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants