Remove low-level coroutine suspension notifications #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tests passed locally... |
kennykerr
reviewed
Nov 11, 2022
| IAsyncAction NoSuspend_IAsyncAction() | ||
| { | ||
| co_await resume_after(0s); | ||
| co_await 0s; |
Collaborator
There was a problem hiding this comment.
What does this change have to do with ripping out the low-level hooks?
Contributor
Author
There was a problem hiding this comment.
This workaround was added because of the low level hooks preventing Clang from building this code.
So removing resume_after helps make sure that we have coverage for this functionality on Clang.
Collaborator
|
It generally looks good to me, but @oldnewthing made the last few tweaks to coroutine support so I'd appreciate his eyes on this change as well. |
oldnewthing
approved these changes
Nov 11, 2022
Member
oldnewthing
left a comment
There was a problem hiding this comment.
I never thought we would be rid of this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opposite of #372
Fixes #1219