Fix misleading Date constructor documentation (addresses #49350)#49649
Merged
sandersn merged 8 commits intomicrosoft:mainfrom Aug 9, 2022
Merged
Fix misleading Date constructor documentation (addresses #49350)#49649sandersn merged 8 commits intomicrosoft:mainfrom
sandersn merged 8 commits intomicrosoft:mainfrom
Conversation
Signed-off-by: jmorrison152 <[email protected]>
Signed-off-by: jmorrison152 <[email protected]>
) (#73) * Update month parameter to monthIndex and add docs for Date constructor Signed-off-by: jmorrison152 <[email protected]> * Add baseline changes Signed-off-by: jmorrison152 <[email protected]>
|
|
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
sandersn
approved these changes
Jul 6, 2022
Member
|
@jackmorrison12 I'll merge this after you have a chance to merge from main. No need to rebase or anything; I'll squash and merge afterward. |
Contributor
|
@sandersn Thanks for the review - this is now updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #49350
Describe your changes
monthtomonthIndexto align with MDN for Date constructor and UTC method (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/Date#syntax)Testing performed
n/a - exclusively documentation changes and a parameter rename, no way to test these. Updated the baseline changes since some line numbers were updated from the change
Fixes #49350