Fix misleading Date constructor documentation (addresses #49350)#73
Merged
mkubilayk merged 2 commits intobloomberg:oss-hackathon-49350from Jun 22, 2022
Merged
Conversation
Signed-off-by: jmorrison152 <[email protected]>
Signed-off-by: jmorrison152 <[email protected]>
449f1d9 to
406cb0e
Compare
mkubilayk
approved these changes
Jun 17, 2022
tchetwin
approved these changes
Jun 17, 2022
Author
|
@mkubilayk @acutmore @dragomirtitian @tchetwin how can I go about getting this merged in? |
|
Reached out to Jack privately about CCLA. |
dragomirtitian
approved these changes
Jun 21, 2022
m-basov
pushed a commit
that referenced
this pull request
Aug 31, 2022
) (microsoft#49649) * Update month parameter to monthIndex and add docs for Date constructor Signed-off-by: jmorrison152 <[email protected]> * Add baseline changes Signed-off-by: jmorrison152 <[email protected]> * Fix misleading Date constructor documentation (addresses microsoft#49350) (#73) * Update month parameter to monthIndex and add docs for Date constructor Signed-off-by: jmorrison152 <[email protected]> * Add baseline changes Signed-off-by: jmorrison152 <[email protected]> * Update baselines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: microsoft#49350
Describe your changes
monthtomonthIndexto align with MDN for Date constructor and UTC method (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/Date#syntax)Testing performed
n/a - exclusively documentation changes and a parameter rename, no way to test these. Updated the baseline changes since some line numbers were updated from the change