AtomBuiltin and decentral Atom box handling#469
Conversation
Member
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cleaner version of the
Atomimplementation used inImage[], that makes it easy to add newAtoms, such asImage[],Graph[], etc. without having to change central code inMakeBoxes.Two changes:
(1) new
AtomBuiltin(from #378); needed as a mechanism to register a builtin-like symbol that is actually anAtom(declaring anAtomdirectly does not register a name that could be used for constructing it in anExpression, so there always has to be an accompanyingBuiltin).(2) moved out logic from
class MakeBoxes(Builtin)into a newAtom.atom_to_boxesmethod, so that newAtoms need not add their logic (and import their symbols) toMakeBoxesbut must instead provide an implementation ofatom_to_boxes.In the current implementation,
MakeBoxesreturnsNoneon unknownAtomtypes. This PR changes this to raising anNotImplementedErrorforAtoms not implementingatom_to_boxes. As implementations are provided forSymbol,Integer,Rational,Real,Complex,String, this might only happen if newAtoms are added that do not properly implementatom_to_boxes.