Skip to content

Comments

Image#378

Closed
sn6uv wants to merge 48 commits intomathics:imathicsfrom
sn6uv:Image
Closed

Image#378
sn6uv wants to merge 48 commits intomathics:imathicsfrom
sn6uv:Image

Conversation

@sn6uv
Copy link
Member

@sn6uv sn6uv commented May 14, 2016

Extends #363.

Still a work in progress.

@sn6uv
Copy link
Member Author

sn6uv commented May 14, 2016

The way it's implemented the entire mathics.builtin.image module doesn't get imported if the libs aren't available. This could cause some confusion and maybe there's a better way to handle it. The main reason for doing it this way is that adding the same error message to every function is tedious. An alternative would be to subclass Builtin and wrap all the apply methods but it's quite hacky that way.

@sn6uv
Copy link
Member Author

sn6uv commented May 15, 2016

Image reflect tests are failing due to #381.

@sn6uv sn6uv force-pushed the Image branch 4 times, most recently from 0214ae8 to 7df4bb6 Compare May 15, 2016 22:39
@sn6uv sn6uv added this to the 1.0 milestone Jun 26, 2016
@ghost
Copy link

ghost commented Jul 23, 2016

reimplementation of parts of this to only depend on Pillow (PyPy compatible) instead of PIL (not PyPy compatible) depends on #400

@ghost ghost mentioned this pull request Aug 16, 2016
@sn6uv sn6uv closed this Aug 16, 2016
@sn6uv sn6uv deleted the Image branch August 16, 2016 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants