Skip to content

Set $InputFileName on mathics_open()#1304

Merged
mmatera merged 3 commits intomasterfrom
set-$InputFileName
Apr 28, 2021
Merged

Set $InputFileName on mathics_open()#1304
mmatera merged 3 commits intomasterfrom
set-$InputFileName

Conversation

@rocky
Copy link
Member

@rocky rocky commented Apr 22, 2021

TODO write a test for this.

@rocky rocky requested a review from mmatera April 22, 2021 19:43
@rocky rocky marked this pull request as draft April 22, 2021 19:43
@mmatera
Copy link
Contributor

mmatera commented Apr 25, 2021

I think the test would be the one that motivated this PR. If that test passes, then we can implement it later in the test engine.

Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatera mmatera marked this pull request as ready for review April 28, 2021 02:36
@mmatera
Copy link
Contributor

mmatera commented Apr 28, 2021

LGTM

I included a simple test for $InputFileName. If passes in all the platforms, I think that this is ready for merging.

@mmatera mmatera merged commit 41a3c30 into master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants