-
-
Notifications
You must be signed in to change notification settings - Fork 205
Filenames implement #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Filenames implement #1173
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
270d818
basic support for FileNames
mmatera ea8d034
adding tests
mmatera 4613fad
fix test and message
mmatera b8e7807
fix Infinity
mmatera 90a0159
including directories in the list
mmatera 6787fd0
Adding URLSave
mmatera 94dc60b
fix doc
mmatera 5afdefa
adding CreateFile and CreateTemporary
mmatera 2d640f5
fix write
mmatera 616dbba
implementing ByteArray
mmatera 8bc767c
adding tests
mmatera b500e70
mark changes
mmatera ea2a748
fixing CSV exporter
mmatera f52ac9c
merge
mmatera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,15 @@ | ||
| CHANGES | ||
| ======= | ||
|
|
||
| New builtins | ||
| ++++++++++++ | ||
| ByteArray | ||
| FileNames | ||
| CreateFile | ||
| CreateTemporary | ||
|
|
||
|
|
||
|
|
||
| 2.0.0 | ||
| ----- | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ | |
| MachineReal, | ||
| PrecisionReal, | ||
| String, | ||
| ByteArrayAtom, | ||
| Symbol, | ||
| ensure_context, | ||
| strip_context, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to think about for the future. I know the convention we've been using is apply with a number afterwards, but I think things would be more meaningful if put something more descriptive in there like
apply_with_filename_parameter()