Conversation
rocky
reviewed
Mar 7, 2021
| 'URLSave[url_String, OptionsPattern[URLSave]]' | ||
| return self.apply_2(url, None, evaluation, **options) | ||
|
|
||
| def apply_2(self, url, filename, evaluation, **options): |
Member
There was a problem hiding this comment.
Something to think about for the future. I know the convention we've been using is apply with a number afterwards, but I think things would be more meaningful if put something more descriptive in there like apply_with_filename_parameter()
rocky
approved these changes
Mar 7, 2021
Member
rocky
left a comment
There was a problem hiding this comment.
LGTM - you can do the merge when you are ready.
After that is in I'll look over in Windows and rebase the windows-compatibility branch off of this, looking to see if there is anything that got fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
FileNames, a symbol required in theFeynCalcpackage (see #1169)