Skip to content

Removed faiss dependency (downstream image) #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
are-ces merged 1 commit into from
Feb 3, 2026
Merged

Removed faiss dependency (downstream image) #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test.containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM quay.io/rhoai/odh-llama-stack-core-rhel9:rhoai-3.3

# Install missing dependencies and create required directories
USER root
RUN pip install faiss-cpu==1.11.0 azure-identity && \
RUN pip install azure-identity && \
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
echo "=== Searching for faiss-cpu references in dependency files ==="
rg "faiss" --type python --type toml --type txt

echo ""
echo "=== Looking for pyproject.toml files ==="
fd -t f "pyproject.toml" -x head -100 {}

echo ""
echo "=== Checking for requirements files ==="
fd -t f "requirements.*" -x head -50 {}

echo ""
echo "=== Checking all Containerfile/Dockerfile files ==="
fd -t f -e Containerfile -e Dockerfile -x cat {}

Repository: lightspeed-core/lightspeed-stack

Length of output: 13900

Faiss-cpu is already managed through the base image's RHOAI wheels index.

The faiss-cpu version is pinned in the RHOAI wheels repository (currently 1.12.0 in requirements.hashes.wheel.txt) and controlled at the base image level (odh-llama-stack-core-rhel9:rhoai-3.3), not as a direct dependency in pyproject.toml. Removing the explicit pip install is consistent with this approach, as the dependency is already supplied by the base image.

Verify that the base image version (rhoai-3.3) includes a compatible faiss-cpu version for the rest of your deployment.

🤖 Prompt for AI Agents 
In `@test.containerfile` at line 6, Remove the explicit pip installation of
faiss-cpu from the Dockerfile layer that contains the RUN pip install
azure-identity command (look for the RUN pip install ... line in
test.containerfile), since faiss-cpu is provided by the base image's RHOAI
wheels index; ensure the RUN line only installs azure-identity (or other
explicit packages) and delete any reference to faiss-cpu, and add a short
comment noting faiss-cpu is supplied by the base image (rhoai-3.3) and to verify
that rhoai-3.3 includes a compatible faiss-cpu version.

mkdir -p /app-root && \
chown -R 1001:0 /app-root && \
chmod -R 775 /app-root && \
Expand Down
Loading