Removed faiss dependency (downstream image)#1097
Removed faiss dependency (downstream image)#1097are-ces merged 1 commit intolightspeed-core:mainfrom
Conversation
WalkthroughA single pip dependency ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@test.containerfile`:
- Line 6: Remove the explicit pip installation of faiss-cpu from the Dockerfile
layer that contains the RUN pip install azure-identity command (look for the RUN
pip install ... line in test.containerfile), since faiss-cpu is provided by the
base image's RHOAI wheels index; ensure the RUN line only installs
azure-identity (or other explicit packages) and delete any reference to
faiss-cpu, and add a short comment noting faiss-cpu is supplied by the base
image (rhoai-3.3) and to verify that rhoai-3.3 includes a compatible faiss-cpu
version.
| # Install missing dependencies and create required directories | ||
| USER root | ||
| RUN pip install faiss-cpu==1.11.0 azure-identity && \ | ||
| RUN pip install azure-identity && \ |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
echo "=== Searching for faiss-cpu references in dependency files ==="
rg "faiss" --type python --type toml --type txt
echo ""
echo "=== Looking for pyproject.toml files ==="
fd -t f "pyproject.toml" -x head -100 {}
echo ""
echo "=== Checking for requirements files ==="
fd -t f "requirements.*" -x head -50 {}
echo ""
echo "=== Checking all Containerfile/Dockerfile files ==="
fd -t f -e Containerfile -e Dockerfile -x cat {}Repository: lightspeed-core/lightspeed-stack
Length of output: 13900
Faiss-cpu is already managed through the base image's RHOAI wheels index.
The faiss-cpu version is pinned in the RHOAI wheels repository (currently 1.12.0 in requirements.hashes.wheel.txt) and controlled at the base image level (odh-llama-stack-core-rhel9:rhoai-3.3), not as a direct dependency in pyproject.toml. Removing the explicit pip install is consistent with this approach, as the dependency is already supplied by the base image.
Verify that the base image version (rhoai-3.3) includes a compatible faiss-cpu version for the rest of your deployment.
🤖 Prompt for AI Agents
In `@test.containerfile` at line 6, Remove the explicit pip installation of
faiss-cpu from the Dockerfile layer that contains the RUN pip install
azure-identity command (look for the RUN pip install ... line in
test.containerfile), since faiss-cpu is provided by the base image's RHOAI
wheels index; ensure the RUN line only installs azure-identity (or other
explicit packages) and delete any reference to faiss-cpu, and add a short
comment noting faiss-cpu is supplied by the base image (rhoai-3.3) and to verify
that rhoai-3.3 includes a compatible faiss-cpu version.
Description
Removed the
faiss-cpupackage which is already included in the downstream image.Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit