Only skip noncritical partitioning in BoundaryMesh#2097
Merged
Conversation
Under the new skip_partitioning semantics, on a DistributedMesh we don't appear to be getting even *initial* nodal partitioning into a valid state.
Member
|
Hey look at that! Looks like you got ...
:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the new skip_partitioning semantics, on a DistributedMesh we
don't appear to be getting even initial nodal partitioning into a
valid state.
This is one of (and if we're really really lucky the only one of) the bugs that seems to be throwing current DistributedMesh sweeps for a loop, foiling #1938 and #2088 tests.
While the initial CI sweeps are running on this fix, I'll start digging for any other
skip_repartitioning()uses that need to be converted toskip_noncritical_repartitioning()to conform to the change in #2061