Skip to content

add spacing and hover state to channel list cards#4574

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
marcellamaki:hover-card-rebrand
May 23, 2024
Merged

add spacing and hover state to channel list cards#4574
bjester merged 1 commit intolearningequality:hotfixesfrom
marcellamaki:hover-card-rebrand

Conversation

@marcellamaki
Copy link
Copy Markdown
Member

Adds just a small quick-fix of margin and slightly darker drop shadow on hover so that the cards don't run into each other.

More substantial fix to be addressed separately.

@marcellamaki marcellamaki requested a review from bjester May 23, 2024 13:59

.list-card-hover {
margin: 16px;
box-shadow: 0 3px 5px 0 rgba(0, 0, 0, 0.2);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we want the cards to have a box shadow when unhovered, we should just remove the flat prop.

Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bjester bjester merged commit b10e013 into learningequality:hotfixes May 23, 2024
@akolson akolson mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants