-
-
Notifications
You must be signed in to change notification settings - Fork 300
More cosmetic issues with rebranded cards #4557
Description
Observed behavior
- The pinned COVID card at the top of the content library has incorrect hover styling
- The collection cards are clipped at the bottom by the following cards on hover
Expected behavior
- The pinned COVID card at the top of the content library has matching hover styling
- The collection cards do not clip each other so the hover styling (shadow) is visible on all edges of the card
User-facing consequences
Cosmetic inconsistencies look bad
Additional information
Looks great @bjester! Just a couple of questions about whether this change should also be applied to the 'Helpful Resources for Covid-19' card at the top of the Content Library and also whether the hover effect is not good enough when selecting channels for a collection. See the following video:
Yeah the global updates I made somehow missed the COVID card at the top of search. We should make it consistent. As for the collection cards, they were initially flat which posed a problem considering we don't really have flat-hovered card style. At the very least, the cards' bottom shouldn't be clipped by the card below. That said, we should probably switch to a regular card, but as it's coded right now, the checkbox needs to be removed from the card itself, which is a bit out of scope of the rebranding changes.
So I lean towards fixing the current cosmetic issues and followup later with proper update for the collection UI. We can probably accomplish revamping the collection cards when we integrate KCard, to avoid unnecessary dev.
Originally posted by @bjester in #4549 (comment)