added text truncate in import channel dropdown#4186
Merged
LianaHarris360 merged 2 commits intolearningequality:unstablefrom Jul 20, 2023
Merged
Conversation
Member
|
Thanks @Jaspreet-singh-1032 for another contribution, this is very helpful |
| } | ||
|
|
||
| .text-truncate-ellipsis { | ||
| max-width: 200px; |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Hey @LianaHarris360, Thanks for the review. I have some queries. Without setting fixed width this does not seem to work because using ellipsis needs a specific width. What I am thinking is to pass a prop to the MultiSelect component that whether it should use ellipsis or not and if yes then what should be the max-width Let me know if you have any other suggestions!
Member
There was a problem hiding this comment.
@Jaspreet-singh-1032 Good idea, that sounds like it should work!
LianaHarris360
approved these changes
Jul 20, 2023
Member
LianaHarris360
left a comment
There was a problem hiding this comment.
The code changes all make sense and it looks great!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #4166
Screenshots (if applicable)
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)