Skip to content

Updates syncing metadata fields on syncing modal#4016

Merged
akolson merged 9 commits intolearningequality:unstablefrom
akolson:syncing-metadata-ui-strings
Apr 14, 2023
Merged

Updates syncing metadata fields on syncing modal#4016
akolson merged 9 commits intolearningequality:unstablefrom
akolson:syncing-metadata-ui-strings

Conversation

@akolson
Copy link
Copy Markdown
Member

@akolson akolson commented Apr 11, 2023

Summary

Description of the change(s) you made

This pr updates the syncing modal to look as shown below;
image

Manual verification steps performed

See #3986

Screenshots (if applicable)

Does this introduce any tech-debt items?

No


Reviewer guidance

How can a reviewer test these changes?

  1. Login into Kolibri studio
  2. Go to /en/channels/#/my-channels
  3. Setup 2 channels, one to upload content to(A), and the other to import content from the first into(B)
  4. Select select channel B and perform the syncing
  5. You should be presented with progress on start syncing and notification on completion of syncing

Are there any risky areas that deserve extra testing?

References

Fixes #3986

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added qa-ready Create a demo server for this pull request and removed work-in-progress labels Apr 13, 2023
@akolson akolson marked this pull request as ready for review April 13, 2023 11:04
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! It'll need some testing, but the only change that I can see is the usage of waitForCopying is unnecessary because of your watch approach. Sorry I threw you off with mentioning that.

@akolson akolson added TODO: needs review and removed qa-ready Create a demo server for this pull request labels Apr 13, 2023
@akolson akolson requested a review from bjester April 13, 2023 16:24
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, everything is good. I have requested some design changes though, for it to better match @jtamiace's designs. It should hopefully make it look like the following:

Before After
Screenshot from 2023-04-13 12-12-39 Screenshot from 2023-04-13 12-07-59
Screenshot from 2023-04-13 11-23-46 Screenshot from 2023-04-13 12-12-05

@akolson
Copy link
Copy Markdown
Member Author

akolson commented Apr 14, 2023

Hi @bjester, the css has been applied as you recommended, with very minor tweaks. All seems to look good now.
image
image
Just a few merge conflicts to resolve and we should be good!

Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! some merge conflicts though

@akolson
Copy link
Copy Markdown
Member Author

akolson commented Apr 14, 2023

All good now. Thanks Blaine!

@akolson akolson merged commit 9e276a3 into learningequality:unstable Apr 14, 2023
@akolson akolson deleted the syncing-metadata-ui-strings branch October 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify UI strings when syncing metadata

2 participants