Updates syncing metadata fields on syncing modal#4016
Merged
akolson merged 9 commits intolearningequality:unstablefrom Apr 14, 2023
Merged
Updates syncing metadata fields on syncing modal#4016akolson merged 9 commits intolearningequality:unstablefrom
akolson merged 9 commits intolearningequality:unstablefrom
Conversation
bjester
requested changes
Apr 13, 2023
Member
bjester
left a comment
There was a problem hiding this comment.
This looks great! It'll need some testing, but the only change that I can see is the usage of waitForCopying is unnecessary because of your watch approach. Sorry I threw you off with mentioning that.
contentcuration/contentcuration/frontend/channelEdit/views/progress/ProgressModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/progress/ProgressModal.vue
Outdated
Show resolved
Hide resolved
bjester
requested changes
Apr 13, 2023
contentcuration/contentcuration/frontend/channelEdit/views/sync/SyncResourcesModal.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/sync/SyncResourcesModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/sync/SyncResourcesModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/sync/SyncResourcesModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/sync/SyncResourcesModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/sync/SyncResourcesModal.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/sync/SyncResourcesModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/sync/SyncResourcesModal.vue
Outdated
Show resolved
Hide resolved
Member
Author
|
Hi @bjester, the css has been applied as you recommended, with very minor tweaks. All seems to look good now. |
bjester
approved these changes
Apr 14, 2023
Member
bjester
left a comment
There was a problem hiding this comment.
Good to go! some merge conflicts though
Member
Author
|
All good now. Thanks Blaine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Summary
Description of the change(s) you made
This pr updates the syncing modal to look as shown below;

Manual verification steps performed
See #3986
Screenshots (if applicable)
Does this introduce any tech-debt items?
No
Reviewer guidance
How can a reviewer test these changes?
/en/channels/#/my-channelsAre there any risky areas that deserve extra testing?
References
Fixes #3986
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)