Skip to content

Updates our frontend sentry config to be harmonized with drawing from secrets in the backend#3782

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles:sentry
Oct 31, 2022
Merged

Updates our frontend sentry config to be harmonized with drawing from secrets in the backend#3782
rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles:sentry

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented Oct 28, 2022

Summary

Description of the change(s) you made

  • Seeing a bunch of errors in sentry from the frontend both from dev environments and from people randomly running forks of Studio, this seemed important to resolve
  • Updates how we do our frontend Sentry integration to use the same DSN, Environment, and Release variables as the backend

I'm not really sure how to test this except to do it live!

References

Fixes #2644

@rtibbles rtibbles requested a review from aronasorman October 28, 2022 22:12
aronasorman
aronasorman approved these changes Oct 31, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aronasorman aronasorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtibbles rtibbles merged commit a986d25 into learningequality:hotfixes Oct 31, 2022
@rtibbles rtibbles deleted the sentry branch October 31, 2022 22:05
@rtibbles rtibbles mentioned this pull request Oct 31, 2022
Closed
@bjester bjester mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aronasorman aronasorman aronasorman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rtibbles @aronasorman