Dropdown consolidation, layout fixes, and RTL updates#3679
Merged
marcellamaki merged 7 commits intolearningequality:hotfixesfrom Sep 30, 2022
Merged
Dropdown consolidation, layout fixes, and RTL updates#3679marcellamaki merged 7 commits intolearningequality:hotfixesfrom
marcellamaki merged 7 commits intolearningequality:hotfixesfrom
Conversation
cf4a00c to
e135891
Compare
marcellamaki
requested changes
Sep 30, 2022
Member
There was a problem hiding this comment.
@bjester this looks great!!
-
The dropdowns in all places you list seem to be working as expected 🎉 I checked, and code review looks good.
✅ Edit modal
✅ Editing channel details
✅ Signing up for a new account
✅ Catalog search
✅ Import search -
The alignment of the checkboxes is also fixed. ✅
-
Needs to be fixed: I don't see the thumbnail changes on RTL that you have a screenshot of 🤔 (I double checked that I wasn't running devserver hot).
- Not blocking, but would be great to add. The last thing is I found two more places where the new dropdown wrapper could be added:
Under administration/user, click on a user listed, and scroll down to the storage space
Member
Author
|
@marcellamaki Updated |
This was referenced Sep 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Background
absolutepositioning instead of thefixedpositioningDescription of the change(s) you made
attachattribute to Vuetify selects, autocompletes, and menusManual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
<DropdownWrapper>for handling viewport resizesReviewer guidance
How can a reviewer test these changes?
Much of the diff comes from wrapping templates with
<DropdownWrapper>References
Fixes #3689
Fixes #3678
Fixes #3666
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)