Skip to content

Topic metadata updates#3671

Merged
bjester merged 2 commits intolearningequality:hotfixesfrom
rtibbles:topic_metadata_updates
Sep 23, 2022
Merged

Topic metadata updates#3671
bjester merged 2 commits intolearningequality:hotfixesfrom
rtibbles:topic_metadata_updates

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented Sep 23, 2022

Summary

Description of the change(s) you made

  • Don't make intervening folders inherit inherited properties
  • Still pass down the properties to descendant resources
  • Adds language as an inherited property

Reviewer guidance

How can a reviewer test these changes?

Add inherited metadata labels and language to a folder - see that on publish in Kolibri, it gets set on descendant resources, but not on the intervening folders.

References

Follow up from QA #3578 (comment)


Contributor's Checklist

Testing:

  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjester bjester merged commit 8c89cc9 into learningequality:hotfixes Sep 23, 2022
@bjester bjester mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants