Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
<ActionLink
v-if="fileDisplay"
class="notranslate"
:text="fileDisplay.original_filename"
:text="formattedFileDisplay"
data-test="file-link"
@click="openFileDialog"
/>
<ActionLink
Expand Down Expand Up @@ -133,6 +134,13 @@
}
return this.file;
},
formattedFileDisplay() {
const fileName = this.fileDisplay.original_filename;
if (fileName === 'file' || !fileName) {
return this.$tr('unknownFile');
}
return fileName;
},
erroredFile() {
if (this.fileUpload && this.fileUpload.error) {
return this.fileUpload;
Expand Down Expand Up @@ -166,6 +174,7 @@
/* eslint-disable kolibri/vue-no-unused-translations */
retryUpload: 'Retry upload',
uploadFailed: 'Upload failed',
unknownFile: 'Unknown filename',
/* eslint-enable kolibri/vue-no-unused-translations */
},
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,28 @@ function makeWrapper(props = {}, file = {}) {

describe('fileUploadItem', () => {
describe('render', () => {
it("'Unknown filename' should be displayed if original_filename is 'file'", () => {
let file = {
original_filename: 'file',
};
let wrapper = makeWrapper({}, file);
expect(wrapper.find('[data-test="file-link"]').text()).toBe('Unknown filename');
});
it("'Unknown filename' should be displayed if original_filename is ''", () => {
let file = {
original_filename: '',
};
let wrapper = makeWrapper({}, file);
expect(wrapper.find('[data-test="file-link"]').text()).toBe('Unknown filename');
});
it("original_filename should be displayed if its value is not 'file'", () => {
let file = {
id: 'file-1',
original_filename: 'SomeFileName',
};
let wrapper = makeWrapper({}, file);
expect(wrapper.find('[data-test="file-link"]').text()).toBe('SomeFileName');
});
it('should show a status error if the file has an error', () => {
let wrapper = makeWrapper({}, { error: true });
expect(wrapper.find('[data-test="status"]').exists()).toBe(true);
Expand Down