adds translated user friendly string for files with no name#3602
Merged
bjester merged 3 commits intolearningequality:unstablefrom Sep 7, 2022
Merged
adds translated user friendly string for files with no name#3602bjester merged 3 commits intolearningequality:unstablefrom
bjester merged 3 commits intolearningequality:unstablefrom
Conversation
bjester
requested changes
Sep 7, 2022
Member
bjester
left a comment
There was a problem hiding this comment.
A check for the case of an empty string doesn't look quite right to me. Adding an additional test for that case may help!
Also, if you wanted to go a little further, I think you could consider removing the defaulting of original_filename to file on the backend, where it was mentioned in the issue. Perhaps, just default to an empty string to save space since saving 'file' to the database is somewhat meaningless. That isn't at all necessary to satisfy the issue though, so it's okay if you don't want to change that
contentcuration/contentcuration/frontend/channelEdit/views/files/FileUploadItem.vue
Outdated
Show resolved
Hide resolved
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This pr translates the hard coded "file" name for all file uploads with no name, particularly those uploaded via
ricecooker. The hard coded "file" remains as is on the backend, but on the frontend it is set to a translated, meaningful string("Unknown filename") to the user.Manual verification steps performed
cd contentcuration./manage.py shellfrom contentcuration.models import FileFile.objects.update(original_filename="file")Screenshots (if applicable)
Before
Please see #3017
After Fix(en)
After Fix(ar) - Arabic doesn't exist so defaults to English as shown in console
Does this introduce any tech-debt items?
No
Reviewer guidance
How can a reviewer test these changes?
Please see Manual verification steps performed above
References
Closes #3017
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)