Skip to content

Fix files on localhost when services are run via Docker#3429

Merged
rtibbles merged 1 commit intolearningequality:unstablefrom
MisRob:fix-local-files-docker
Jun 22, 2022
Merged

Fix files on localhost when services are run via Docker#3429
rtibbles merged 1 commit intolearningequality:unstablefrom
MisRob:fix-local-files-docker

Conversation

@MisRob
Copy link
Copy Markdown
Member

@MisRob MisRob commented Jun 17, 2022

Summary

Similarly to #2777, this PR fixes files preview and upload locally, but this time when services are run via Docker. It does so by adding http://127.0.0.1:8080 address to MINIO_API_CORS_ALLOW_ORIGIN Docker configuration (therefore it matches our minio configuration in package.json used we running services without Docker). This fixes the No 'Access-Control-Allow-Origin' header is present on the requested resource. CORS error:

Screenshot from 2022-06-17 14-24-05

Manual verification steps performed

  1. Navigate to a channel
  2. Open the side panel of a document resource that has some files and see that the file preview is rendered and there is no CORS error in the console

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

when running services via Docker
@MisRob MisRob requested a review from rtibbles June 17, 2022 12:34
@rtibbles rtibbles merged commit a0d4563 into learningequality:unstable Jun 22, 2022
@MisRob MisRob deleted the fix-local-files-docker branch November 28, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants