Fix files on localhost when services are run via Docker#3429
Merged
rtibbles merged 1 commit intolearningequality:unstablefrom Jun 22, 2022
Merged
Fix files on localhost when services are run via Docker#3429rtibbles merged 1 commit intolearningequality:unstablefrom
rtibbles merged 1 commit intolearningequality:unstablefrom
Conversation
when running services via Docker
rtibbles
approved these changes
Jun 22, 2022
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Similarly to #2777, this PR fixes files preview and upload locally, but this time when services are run via Docker. It does so by adding
http://127.0.0.1:8080address toMINIO_API_CORS_ALLOW_ORIGINDocker configuration (therefore it matches our minio configuration in package.json used we running services without Docker). This fixes theNo 'Access-Control-Allow-Origin' header is present on the requested resource.CORS error:Manual verification steps performed
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)