Skip to content

Add localhost to minio allowed origins#2777

Merged
rtibbles merged 1 commit intolearningequality:developfrom
MisRob:minio-cors-fix
Jan 14, 2021
Merged

Add localhost to minio allowed origins#2777
rtibbles merged 1 commit intolearningequality:developfrom
MisRob:minio-cors-fix

Conversation

@MisRob
Copy link
Copy Markdown
Member

@MisRob MisRob commented Jan 14, 2021

Description

Fixes CORS issues with file upload failing locally.

Checklist

  • Is the code clean and well-commented?
  • Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  • Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  • Are there tests for this change?
  • Are all user-facing strings translated properly (if applicable)?
  • Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Are views organized into pages, components, and layouts directories as described in the docs?
  • Are users' storage used being recalculated properly on any changes to their main tree files?
  • Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  • Are there any new interactions that need to be added to the QA Sheet?
  • Are there opportunities for using Google Analytics here (if applicable)?
  • If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  • Are the migrations safe for a large db (if applicable)?

@MisRob MisRob requested a review from rtibbles January 14, 2021 18:24
@rtibbles rtibbles merged commit 39f37c6 into learningequality:develop Jan 14, 2021
This was referenced Jan 14, 2021
@MisRob MisRob deleted the minio-cors-fix branch February 3, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants