Fix partial updating of completion criteria#3383
Merged
sairina merged 2 commits intolearningequality:unstablefrom May 13, 2022
Merged
Fix partial updating of completion criteria#3383sairina merged 2 commits intolearningequality:unstablefrom
sairina merged 2 commits intolearningequality:unstablefrom
Conversation
Move validation of completion criteria to update method to run validation, on the update version.
sairina
approved these changes
May 13, 2022
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
#3382 did a lot of good things, but failed to account for partial updates of completion criteria - as such, the validation happens prematurely, so that if a change is just made to the threshold, and not the model, validation will fail because threshold is missing from the update.
This defers validation until after the instance has been updated in memory, and runs validation then, before any save has happened, therefore triggering a validation error and preventing incorrect data from being saved.
Manual verification steps performed