Skip to content

Fix two previously unreported bugs in nested updates to extra_fields#3382

Merged
sairina merged 4 commits intolearningequality:unstablefrom
rtibbles:itsbugsallthewaydown
May 11, 2022
Merged

Fix two previously unreported bugs in nested updates to extra_fields#3382
sairina merged 4 commits intolearningequality:unstablefrom
rtibbles:itsbugsallthewaydown

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Fixes a bug whereby if the 'options' key or any other subkey of extra_fields did not exist, it would break upon assignment of a sub key
  • Fixes a bug where completion criteria would not get updated inside the options object by ensuring that the writable keys are explicitly described on a serializer - there's some slight redundancy as a result
  • Creates regression tests for the two bugs above

@rtibbles rtibbles force-pushed the itsbugsallthewaydown branch from 2727514 to 900089c Compare May 11, 2022 22:49
@sairina sairina merged commit 8d54b87 into learningequality:unstable May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants