Make sure to always annotate can_edit and can_view.#3126
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Apr 28, 2021
Merged
Make sure to always annotate can_edit and can_view.#3126rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles merged 1 commit intolearningequality:hotfixesfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## hotfixes #3126 +/- ##
============================================
+ Coverage 80.80% 86.16% +5.35%
============================================
Files 281 305 +24
Lines 12659 16476 +3817
============================================
+ Hits 10229 14196 +3967
+ Misses 2430 2280 -150
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Fixes regression whereby can_edit and can_view were not getting annotated on the User queryset for the ChannelUser endpoint.
Adds regression test to try to catch this in the future.
Fixes #3125